autosharding: add config parsing functionality - #9323
Conversation
easwars
added
Type: Feature
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9323 +/- ##
==========================================
- Coverage 83.26% 83.16% -0.11%
==========================================
Files 423 424 +1
Lines 35236 35286 +50
==========================================
+ Hits 29341 29347 +6
- Misses 4402 4433 +31
- Partials 1493 1506 +13
🚀 New features to boost your workflow:
|
|
FYI: @pawbhard @shivaspeaks |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the experimental autosharding load balancing policy, including its configuration parser and unit tests. The review feedback highlights two important improvements: first, implementing the isLoadBalancingConfig marker interface method directly on *lbConfig instead of embedding the interface to prevent potential nil pointer dereference panics; second, updating the validation error messages in ParseConfig to use camelCase field names to match the defined JSON tags.
eshitachandwani
left a comment
eshitachandwani
left a comment
There was a problem hiding this comment.
LGTM modulo one comment
| "google.golang.org/grpc/serviceconfig" | ||
| ) | ||
|
|
||
| func TestParseConfig_Success(t *testing.T) { |
There was a problem hiding this comment.
We might want to make them functions of grpctest.Tester
2 participants
RELEASE NOTES: none